Skip to content

Fix MCP tool schema types to resolve Gemini CLI compatibility issues #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

Fix MCP tool schema types to resolve Gemini CLI compatibility issues #59

merged 1 commit into from
Oct 2, 2025

Conversation

vchomakov
Copy link
Contributor

Problem

Gemini CLI was skipping several Redis MCP tools due to missing or incomplete type information in their parameter schemas:

Skipping tool 'set_vector_in_hash' from MCP server 'redis-mcp' because it has missing types in its parameter schema.
Skipping tool 'json_set' from MCP server 'redis-mcp' because it has missing types in its parameter schema.
Skipping tool 'vector_search_hash' from MCP server 'redis-mcp' because it has missing types in its parameter schema.

Solution

This PR enhances type annotations and schema definitions across all MCP tool modules to ensure proper schema generation and compatibility with strict MCP clients like Gemini CLI.

Changes Made

  • Enhanced type annotations: Added proper type hints for all tool parameters across 9 tool modules
  • Custom type definitions: Implemented JsonValue custom Pydantic type for flexible JSON parameter handling
  • Schema validation: Ensured all tools generate complete parameter schemas with proper type information
  • Consistency improvements: Standardized typing patterns across all tool modules

bobymicroby
bobymicroby approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@bobymicroby bobymicroby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tishun
tishun approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vchomakov vchomakov merged commit 41e3851 into main Oct 2, 2025
19 checks passed
@tishun tishun deleted the fix/mcp-tool-schema-types branch October 3, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobymicroby bobymicroby bobymicroby approved these changes

@tishun tishun tishun approved these changes

@mortensi mortensi Awaiting requested review from mortensi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vchomakov @bobymicroby @tishun